Refactor - extract ingest processors functionality into separate libraries#140206
Merged
eyalkoren merged 21 commits intoelastic:mainfrom Feb 9, 2026
Merged
Conversation
…gest-processors-functionality
…gest-processors-functionality
7 tasks
…gest-processors-functionality
…gest-processors-functionality
…gest-processors-functionality
…gest-processors-functionality
elasticsearchmachine
added
the
needs:triage
eyalkoren
added
>feature
:Distributed/Ingest Node
elasticsearchmachine
added
Team:Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
…gest-processors-functionality
masseyke
reviewed
Feb 4, 2026
libs/web-utils/src/main/java/org/elasticsearch/web/RegisteredDomain.java
Show resolved
Hide resolved
masseyke
reviewed
Feb 4, 2026
libs/web-utils/src/main/java/org/elasticsearch/web/RegisteredDomain.java
Show resolved
Hide resolved
masseyke
reviewed
Feb 4, 2026
masseyke
reviewed
Feb 4, 2026
Member
|
Aside from the questions I added, it looks like what we had discussed. I'm tagging es-core-infra for review since I've never added a new thing under |
masseyke
reviewed
Feb 4, 2026
...mon/src/yamlRestTest/resources/rest-api-spec/test/ingest/390_registered_domain_processor.yml
Outdated
Show resolved
Hide resolved
rjernst
reviewed
Feb 4, 2026
test/framework/src/main/java/org/elasticsearch/bootstrap/TestScopeResolver.java
Outdated
Show resolved
Hide resolved
masseyke
approved these changes
Feb 5, 2026
…gest-processors-functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
grokanddissect, there are additional functionalities we want to share across ingest processors and ES|QL commands.This PR extracts the core functionality from the following processors into a shared library:
UriPartsProcessorUserAgentProcessorRegisteredDomainProcessorNotes for reviewer
RegisteredDomainProcessorrefactor, apache'shttpclientdependencies were moved fromingest-commonto the newweb-utilsmodule. As part of the functionality thatRegisteredDomainis using it for, it requires a file-read permission. When it was located iningest-common, this permission was granted by the entitlements system becausehttpclientwas loaded within aPLUGINscope. However, since it is now located in a separate library, it gets theUNKNOWNscope in tests. I fixed that with a specific exception throughTestScopeResolver. I expected to see the same issue in integration tests, but I added such for theregistered_domainprocessor and they pass. So I am not sure what handles that in production, but it seems to be OK. Please verify that I a not missing anything.