Store raw pattern text fields in binary doc values#140191
Merged
Kubik42 merged 8 commits intoelastic:mainfrom Jan 15, 2026
Merged
Store raw pattern text fields in binary doc values#140191Kubik42 merged 8 commits intoelastic:mainfrom
Kubik42 merged 8 commits intoelastic:mainfrom
Conversation
Kubik42
added
>enhancement
Team:StorageEngine
:StorageEngine/Logs
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
Kubik42
force-pushed
the
pattern-text-binary-doc-values
branch
3 times, most recently
from
0e9ff30 to
ba79a47
Compare
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
Kubik42
force-pushed
the
pattern-text-binary-doc-values
branch
6 times, most recently
from
897ebc1 to
90697ab
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
...sdb/src/main/java/org/elasticsearch/xpack/logsdb/patterntext/PatternTextCompositeValues.java
Outdated
Show resolved
Hide resolved
Contributor
parkertimmins
left a comment
parkertimmins
left a comment
There was a problem hiding this comment.
Looks really good overall! Just a few comments.
.../logsdb/src/main/java/org/elasticsearch/xpack/logsdb/patterntext/PatternTextFieldMapper.java
Outdated
Show resolved
Hide resolved
.../logsdb/src/main/java/org/elasticsearch/xpack/logsdb/patterntext/PatternTextFieldMapper.java
Outdated
Show resolved
Hide resolved
Kubik42
force-pushed
the
pattern-text-binary-doc-values
branch
from
55cc672 to
50d2a23
Compare
Kubik42
commented
Jan 14, 2026
...per-extras/src/main/java/org/elasticsearch/index/mapper/extras/MatchOnlyTextFieldMapper.java
Outdated
Show resolved
Hide resolved
Kubik42
commented
Jan 14, 2026
server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java
Show resolved
Hide resolved
Kubik42
force-pushed
the
pattern-text-binary-doc-values
branch
3 times, most recently
from
4bcf941 to
2c6bb56
Compare
martijnvg
approved these changes
Jan 15, 2026
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Left minor comments, LGTM otherwise.
...sdb/src/main/java/org/elasticsearch/xpack/logsdb/patterntext/PatternTextCompositeValues.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class PatternTextRollingUpgradeIT extends AbstractStringTypeLogsdbRollingUpgradeTestCase { | ||
|
|
||
| private static final String MIN_VERSION = "gte_v9.2.0"; |
Member
There was a problem hiding this comment.
Shouldn't this be gte_v9.3.0? But maybe we should use a cluster feature instead?
Contributor
Author
There was a problem hiding this comment.
I used the same version as in the existing rolling upgrade test.
Would cluster feature make a big difference? The feature check is the same function call for both version and specific feature isn't it?
...sdb/src/main/java/org/elasticsearch/xpack/logsdb/patterntext/PatternTextCompositeValues.java
Outdated
Show resolved
Hide resolved
…used # Conflicts: # rest-api-spec/build.gradle # server/src/test/java/org/elasticsearch/index/mapper/blockloader/TextFieldBlockLoaderTests.java # test/framework/src/main/java/org/elasticsearch/index/mapper/BlockLoaderTestCase.java
# Conflicts: # libs/swisshash/src/main/java/module-info.java # x-pack/plugin/logsdb/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/xpack/logsdb/KeywordRollingUpgradeIT.java
# Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # server/src/main/java/org/elasticsearch/index/mapper/MultiValuedBinaryDocValuesField.java # server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java
# Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java
Kubik42
force-pushed
the
pattern-text-binary-doc-values
branch
from
2c6bb56 to
56d60ca
Compare
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
* Use stored fallback fields when time series doc values format is not used # Conflicts: # rest-api-spec/build.gradle # server/src/test/java/org/elasticsearch/index/mapper/blockloader/TextFieldBlockLoaderTests.java # test/framework/src/main/java/org/elasticsearch/index/mapper/BlockLoaderTestCase.java * testing * Migrate TextRollingUpgradeIT to run in serverless # Conflicts: # libs/swisshash/src/main/java/module-info.java # x-pack/plugin/logsdb/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/xpack/logsdb/KeywordRollingUpgradeIT.java * Store fallback text fields in binary doc values # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # server/src/main/java/org/elasticsearch/index/mapper/MultiValuedBinaryDocValuesField.java # server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java * Store fallback match only text fields in binary doc values * Use binary doc values instead of stored fields for pattern text # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java * Renamed usesBinaryDocValues to be more clear what its used for * Use simple BinaryDocValues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/elastic/logs-program/issues/22