Revert "Return NOT_PREFERRED decisions in allocation explain (#137228)"#140175
Revert "Return NOT_PREFERRED decisions in allocation explain (#137228)"#140175joshua-adams-1 wants to merge 5 commits intoelastic:mainfrom
Conversation
…#137228)" elastic#137228 is suspected to break the nightly performance benchmarks. However, since it introduced a new TransportVersion `ADD_NOT_PREFERRED_ALLOCATION_DECISION`, a simple git revert is not sufficient. This change introduces a reversion TransportVersion `REVERT_ADD_NOT_PREFERRED_ALLOCATION_DECISION` which undoes the above change, and this in time will be unreverted when the problem is resolved
joshua-adams-1
added
>bug
:Distributed/Allocation
|
Hi @joshua-adams-1, I've created a changelog YAML for you. |
| @@ -1 +1 @@ | |||
| search_response_origin_cluster_label,9255000 | |||
| revert_add_not_preferred_allocation_decision,9256000 | |||
There was a problem hiding this comment.
Huh, I think there's a file missing, if I'm not mistaken: this should be associated with another file called src/main/resources/transport/definitions/referable/revert_add_not_preferred_allocation_decision.csv.
Did you use the Gradle transport version task to generate this?
I might have to tag in @jdconrad to confirm.
There was a problem hiding this comment.
IIRC, that file falls under the radar, since it's newly generated and must be manually found and git added. So it might be sitting in Joshua's file directory.
There was a problem hiding this comment.
@DiannaHohensee is correct. That's what I would check first.
There was a problem hiding this comment.
Good catch! Sorry, I missed that when pushing
prdoyle
left a comment
prdoyle
left a comment
There was a problem hiding this comment.
The transport version portion of this looks correct.
5 participants
#137228 is suspected to break the nightly performance benchmarks. However, since it introduced a new
TransportVersionADD_NOT_PREFERRED_ALLOCATION_DECISION, a simple git revert is not sufficient. This change introduces a reversionTransportVersionREVERT_ADD_NOT_PREFERRED_ALLOCATION_DECISIONwhich undoes the above change, and this in time will be unreverted when the problem is resolved