Stabilize and Optimize MMR Result Diversification#140066
Merged
markjhoy merged 8 commits intoelastic:mainfrom Jan 9, 2026
Merged
Stabilize and Optimize MMR Result Diversification#140066markjhoy merged 8 commits intoelastic:mainfrom
markjhoy merged 8 commits intoelastic:mainfrom
Conversation
markjhoy
added
>test
elasticsearchmachine
added
the
Team:Search - Relevance
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
elasticsearchmachine
removed
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Contributor
Author
|
@ioanatia - I think this might be fixed now... I've optimized and thoroughly tested this locally, and I cannot get it to reproduce anymore (it was reproducibly locally before my changes). Let me know your thoughts here. |
ioanatia
approved these changes
Jan 9, 2026
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
markjhoy
added a commit
to markjhoy/elasticsearch
that referenced
this pull request
Jan 9, 2026
* stabilize/optimize MMR result diversification * fix unit tests (cherry picked from commit 88c87b0) # Conflicts: # muted-tests.yml
jimczi
pushed a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 12, 2026
* stabilize/optimize MMR result diversification * fix unit tests
markjhoy
added a commit
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More MMR result diversification tests were failing (and tests were muted). This stabilizes those better guaranteeing the order of the outputs, and optimizes the MMR calculations.
This also unmutes the failed tests: