Enable the Panama Vector API in the Test base plugin#139769
Merged
ChrisHegarty merged 7 commits intoelastic:mainfrom Dec 19, 2025
Merged
Enable the Panama Vector API in the Test base plugin#139769ChrisHegarty merged 7 commits intoelastic:mainfrom
ChrisHegarty merged 7 commits intoelastic:mainfrom
Conversation
ChrisHegarty
added
>test
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Dec 19, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
My one, major concern, is, do we lose significant coverage? I am hoping not? Our comparisons vs. regular java and panama are all still ran as normal right?
Contributor
Author
Yes, exactly. That does not change. Any pamana implementations are compared in specific unit tests against default implementation. |
thecoop
added a commit
that referenced
this pull request
Jan 7, 2026
Follow on from #139769 to update some more tests for FP differences
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jan 7, 2026
Follow on from elastic#139769 to update some more tests for FP differences
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Jan 7, 2026
Follow on from elastic#139769 to update some more tests for FP differences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables the Panama Vector API in the Test base plugin.
We have more and more usage of the Vector API to provide optimized implementations of certain algorithms, the most recent being a Swiss Tables hash. Rather than continuing to enable selectively for some submodules, lets just enable it in the base test plugin. Default scalar implementations are already tested by low-level unit tests, where the Panama implementation is compared to the default. We also ship with the Panama impl, so best test with it.
There are some small changes in this PR that allow for the rounding due to the ordering effects of SIMD on floating-point arithmetic, as is done elsewhere. As well as the toString of some vector scorers.
This PR has been filed in order to extract out changes from a larger PR, namely #139343.