Skip to content

Parameterize the vector operation benchmark tests#139735

Merged
thecoop merged 3 commits intoelastic:mainfrom
thecoop:more-parameterized-benchmarks
Dec 18, 2025
Merged

Parameterize the vector operation benchmark tests#139735
thecoop merged 3 commits intoelastic:mainfrom
thecoop:more-parameterized-benchmarks

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Dec 18, 2025

Also a bit of tidying and consolidation. The extra interface call doesn't have a noticeable effect on the benchmark results

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search labels Dec 18, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0 labels Dec 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldematte
Copy link
Contributor

The extra interface call doesn't have a noticeable effect on the benchmark results

I think that's fair, the way JMH runs benchmarks with warmup should allow the JIT to optimize it away. I wonder if method handles would be more or less efficient here, but if we see that using an interface is OK I'm for it.
We usually invoke these functions via interfaces/base classes anyway (e.g. scorers)

@thecoop thecoop merged commit b96d4d5 into elastic:main Dec 18, 2025
36 checks passed
@thecoop thecoop deleted the more-parameterized-benchmarks branch December 18, 2025 16:53
szybia added a commit to szybia/elasticsearch that referenced this pull request Dec 19, 2025
* upstream/main: (253 commits)
  Adds ST_SIMPLIFY geo spatial function (elastic#136309)
  Take control of max clause count verification in Lucene searcher (elastic#139752)
  [ML] Unmute Inference Test (elastic#139765)
  Parameterize the vector operation benchmark tests (elastic#139735)
  Fix node reduction pushdown tests for release tests (elastic#139548)
  Fix flakiness in TSDataGenerationHelper (elastic#139759)
  CPS: Copy existing resolved index expressions when constructing a new `SearchRequest` from an existing one (elastic#139596)
  Add release notes for v9.1.9 release (elastic#139674)
  Add lucene query for wildcards on high cardinality keyword fields. (elastic#139746)
  Suppress Tika entitlement warnings from AWT (elastic#139711)
  Check field storage when synthetic source is enabled, in tests (elastic#139715)
  Refactor VectorSimilarityType to know about its corresponding Function (elastic#139678)
  Merge fixes from patch branch back into main (elastic#139721)
  Define native bulk operations for vector square distance (elastic#139198)
  Use LongUpDownCounter for Linked Project Error Metrics (elastic#139657)
  ESQL: Add javadoc that explains version-aware planning (elastic#139706)
  Add helper to pick node for reindex relocation (elastic#139081)
  Fix auth serialization randomized version test (elastic#139182)
  ES|QL - Add parsing, preanalysis and analysis timing information to profile (elastic#139540)
  Mute org.elasticsearch.persistent.ClusterPersistentTasksCustomMetadataTests testMinVersionSerialization elastic#139741
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants