Fix native array integration tests#139577
Merged
jordan-powers merged 6 commits intoelastic:mainfrom Dec 18, 2025
Merged
Conversation
jordan-powers
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Jan 29, 2026
In elastic#139093 we updated the NativeArrayIntegrationTestCase to extract the single value out of arrays of length 1. This prevents the creation of the .offsets field (as it's not need for single-valued fields), which then fails the later assertion in the test which checks for the presence of this .offsets field. This PR fixes the test failures by reverting the logic to collapse the arrays, instead maintaining single-valued arrays as-is. (cherry picked from commit 5f24987) # Conflicts: # muted-tests.yml
jordan-powers
added a commit
that referenced
this pull request
Jan 30, 2026
In #139093 we updated the NativeArrayIntegrationTestCase to extract the single value out of arrays of length 1. This prevents the creation of the .offsets field (as it's not need for single-valued fields), which then fails the later assertion in the test which checks for the presence of this .offsets field. This PR fixes the test failures by reverting the logic to collapse the arrays, instead maintaining single-valued arrays as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #139093 we updated the NativeArrayIntegrationTestCase to extract the single value out of arrays of length 1.
This prevents the creation of the
.offsetsfield (as it's not need for single-valued fields), which then fails the later assertion in the test which checks for the presence of this.offsetsfield.This PR fixes the test failures by reverting the logic to collapse the arrays, instead maintaining single-valued arrays as-is.
Fixes #139376.
Fixes #139562.
Fixes #139658.