Skip to content

Fix release test for node_reduction profiling #139515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosdelest merged 1 commit into from
Dec 17, 2025
Merged

Fix release test for node_reduction profiling #139515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,12 +433,6 @@ tests:
- class: org.elasticsearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT
method: test {yaml=index/100_field_name_length_limit/Test field name length limit array synthetic source}
issue: https://github.com/elastic/elasticsearch/issues/139300
- class: org.elasticsearch.xpack.esql.qa.single_node.RestEsqlIT
method: testProfile {SYNC}
issue: https://github.com/elastic/elasticsearch/issues/139303
- class: org.elasticsearch.xpack.esql.qa.single_node.RestEsqlIT
method: testProfile {ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/139304
- class: org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT
method: test {yaml=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification single index float type}
issue: https://github.com/elastic/elasticsearch/issues/139335
Expand Down
8 changes: 7 additions & 1 deletion ...le-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/RestEsqlIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,13 @@ public void testProfile() throws IOException {
assertFalse(plan.containsKey("reduction_nanos"));
}
case "node_reduce" -> {
assertThat((int) plan.get("reduction_nanos"), greaterThanOrEqualTo(0));
if (Build.current().isSnapshot()) {
// Node reduction depends on a pragma for now, so not available on non-snapshot builds - timing won't be available
assertThat((int) plan.get("reduction_nanos"), greaterThanOrEqualTo(0));
} else {
// Remove the if and check reduction_nanos is there when the following fails
assertNull(plan.get("reduction_nanos"));
}
assertFalse(plan.containsKey("logical_optimization_nanos"));
assertFalse(plan.containsKey("physical_optimization_nanos"));
}
Expand Down