Skip to content

Comments

Mark bloom filter files for random access#139375

Merged
fcofdez merged 2 commits intoelastic:mainfrom
fcofdez:random-readadvice-bloom-filter
Jan 7, 2026
Merged

Mark bloom filter files for random access#139375
fcofdez merged 2 commits intoelastic:mainfrom
fcofdez:random-readadvice-bloom-filter

Conversation

@fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Dec 11, 2025

Bloom filter files (.sfbf) are accessed randomly during point lookups
rather than sequentially, so mark them with ReadAdvice.RANDOM
to prevent unnecessary sequential pre-fetching that would waste
I/O resources.

Bloom filter files (.sfbf) are accessed randomly during point lookups
rather than sequentially, so mark them with ReadAdvice.RANDOM to prevent
unnecessary sequential pre-fetching that would waste I/O resources.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez
Copy link
Contributor Author

fcofdez commented Jan 7, 2026

@elasticmachine update branch

@fcofdez fcofdez merged commit f1a1ed4 into elastic:main Jan 7, 2026
35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 7, 2026
* upstream/main: (191 commits)
  Overall Decision for Deciders prioritizes THROTTLE (elastic#140237)
  Apply group by all logic not only to top-level aggregates (elastic#140248)
  [ES|QL] Refactor MV_UNION and MV_INTERSECTION to use shared set operation helper (elastic#139982)
  Avoid reading entire bloom filter file on reader open (elastic#139374)
  Mark bloom filter files for random access (elastic#139375)
  Ensure that the buffer used for ES93BloomFilterStoredFieldsFormat is zeroed (elastic#139034)
  Add busy assertion to avoid race condition for testStalledShardMigrationProperlyDetected (elastic#140230)
  Remove line number check for testTransitiveFindsDeepCallChain (elastic#140228)
  Allow a slight difference in rescored docs (elastic#139931)
  Mute org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT testCreatesEisChatCompletion_DoesNotRemoveEndpointWhenNoLongerAuthorized elastic#138480
  Start exchange sink fetchers concurrently (elastic#140196)
  Allow allocation to replacement target node on vacate completion (elastic#140150)
  Ignore JNA cleaner threads in SecureHdfsRepositoryAnalysisRestIT (elastic#139925)
  DeterministicQueue refactor and enhancement (elastic#140151)
  Always error out if CCS expression shows up when CCS is not supported (elastic#139009)
  Use IllegalArgumentException over RepositoryException for readonly-repository checks (elastic#140200)
  Guard promql capabilities in AnalyzerTests (elastic#140232)
  [Inference API] Fix flaky AuthorizationTaskExecutorIT tests (elastic#139978)
  Cleaning up exitable vector value impls (elastic#140190)
  [Inference API] Fix auth exception listener not called bug (elastic#139966)
  ...
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
Bloom filter files (.sfbf) are accessed randomly during point lookups
rather than sequentially, so mark them with ReadAdvice.RANDOM to prevent
unnecessary sequential pre-fetching that would waste I/O resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants