Skip to content

Fix auth serialization randomized version test #139182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfreden merged 4 commits into from
Dec 18, 2025
Merged

Fix auth serialization randomized version test #139182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11bd927
Fix auth serialization randomized version test
jfreden Dec 8, 2025
5e3b611
fixup! special case for same version
jfreden Dec 8, 2025
431068b
Merge branch 'main' into fix_auth_serialization_test
jfreden Dec 10, 2025
f05cad2
Merge remote-tracking branch 'upstream/main' into fix_auth_serializat…
jfreden Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,6 @@ tests:
- class: org.elasticsearch.xpack.search.AsyncSearchConcurrentStatusIT
method: testConcurrentStatusFetchWhileTaskCloses
issue: https://github.com/elastic/elasticsearch/issues/138543
- class: org.elasticsearch.xpack.core.security.authc.AuthenticationTests
method: testMaybeRewriteForOlderVersionWithCrossClusterAccessRewritesAuthenticationInMetadata
issue: https://github.com/elastic/elasticsearch/issues/139167
- class: org.elasticsearch.smoketest.MlWithSecurityIT
method: test {yaml=ml/sparse_vector_search/Test sparse_vector search with query vector and pruning config}
issue: https://github.com/elastic/elasticsearch/issues/139196
Expand Down
5 changes: 3 additions & 2 deletions ...n/core/src/test/java/org/elasticsearch/xpack/core/security/authc/AuthenticationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,6 @@ public void testBwcWithStoredAuthenticationHeaders() throws IOException {
}

public void testMaybeRewriteForOlderVersionWithCrossClusterAccessRewritesAuthenticationInMetadata() throws IOException {
randomTransportVersion(Authentication.VERSION_CROSS_CLUSTER_ACCESS);
final TransportVersion version = randomTransportVersion(Authentication.VERSION_CROSS_CLUSTER_ACCESS);
final Authentication innerAuthentication = AuthenticationTestHelper.builder().transportVersion(version).build();
final Authentication authentication = AuthenticationTestHelper.builder()
Expand All @@ -883,7 +882,9 @@ public void testMaybeRewriteForOlderVersionWithCrossClusterAccessRewritesAuthent
new CrossClusterAccessSubjectInfo(innerAuthentication, RoleDescriptorsIntersection.EMPTY)
)
.build();
final TransportVersion maybeOldVersion = randomTransportVersion(Authentication.VERSION_CROSS_CLUSTER_ACCESS);
final TransportVersion maybeOldVersion = Authentication.VERSION_CROSS_CLUSTER_ACCESS == version
? version
: randomTransportVersionBetween(Authentication.VERSION_CROSS_CLUSTER_ACCESS, version);

final Authentication actual = authentication.maybeRewriteForOlderVersion(maybeOldVersion);

Expand Down