-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[ES|QL] Run aggregations on aggregate metric double with default metric #138647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
limotova
merged 14 commits into
elastic:main
from
limotova:agg-metric-fuse-default-values
Dec 17, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1af0a96
[ES|QL] Run aggregations on agg_metric with default metric
limotova 83076ac
fix analyzer test
limotova 3dc819e
Merge branch 'main' into agg-metric-fuse-default-values
limotova 282f3b9
bring back some implicit casting changes
limotova 9f66c5d
fix implicit casting..
limotova 354ee75
pivot attempt
limotova fa6e416
Merge branch 'main' into agg-metric-fuse-default-values
limotova 676ce31
remove unnecessary conversion of default metric to max
limotova 2d80a5b
Update docs/changelog/138647.yaml
limotova a4120a3
manually adjust changelog
limotova f225e82
add test with min as default metric
limotova 8adaaf4
round stddev just in case
limotova 479d85f
Merge branch 'main' into agg-metric-fuse-default-values
limotova 58f2105
Merge branch 'main' into agg-metric-fuse-default-values
limotova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| pr: 138647 | ||
| summary: Run aggregations on aggregate metric double with default metric | ||
| area: ES|QL | ||
| type: feature | ||
| issues: | ||
| - 136297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ public int hashCode() { | |
|
|
||
| enum Function { | ||
| AMD_COUNT, | ||
| AMD_DEFAULT, | ||
| AMD_MAX, | ||
| AMD_MIN, | ||
| AMD_SUM, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn't use the TS command but tests with this capability only get run as EsqlSpecIT, and not as CSV tests, and I was running into issues running these tests through the CSV framework and did not think it was worth it to debug, so I added this capability.