ESQL: Added timezone support to date_format and date_parse#138517
ESQL: Added timezone support to date_format and date_parse#138517ivancea merged 30 commits intoelastic:mainfrom
Conversation
ivancea
added
>feature
Team:Analytics
|
Hi @ivancea, I've created a changelog YAML for you. |
ivancea
changed the title
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
There was a problem hiding this comment.
Kibana signatures were also wrong if the first parameter of a function was optional, if the second parameter wasn't.
They were rendered as "1 optional param" instead of "1 required param (the second one)". For a real example, it was "allowing" DATE_FORMAT(), when that wouldn't work.
This is how it looks now in Kibana. Note the "expected ([date])", which makes no sense as it's not optional when alone.
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
...n/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/FoldNullTests.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/DocsV3Support.java
Show resolved
Hide resolved
...lugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/DocsV3Support.java
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/esql/expression/function/AbstractFunctionTestCase.java
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DateParseTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DateParseTests.java
Show resolved
Hide resolved
...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/EsqlFunctionRegistry.java
Show resolved
Hide resolved
There was a problem hiding this comment.
- Most of the changes appear to be the expected configuration plumbing.
- I had no difficulty following the code apart from a few index calculations
in the tests and doc generation where I couldn't quite convince myself
the index wouldn't go out of bound. The assert added by @ivancea helped. I did see a few trivial things likeand left a few trivial suggestions..debug
I did not notice the.debugimproved the output of the neighboring.info.
cimequinox
left a comment
cimequinox
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments.
* upstream/main: (25 commits) Add spec for project routing CRUD REST API endpoints (elastic#139634) Implement AllSupportedFIeldsTestCase for TDigest (elastic#139744) Mute elastic#139802 (elastic#139803) fix(logsdb): batch bulk indexing to prevent OOM in challenge tests (elastic#139770) Documentation for semantic_text auto pre-filtering (elastic#139749) Always do bulk scoring for rescoring when possible (elastic#139777) Optimize script sorts that do not require query scores (elastic#139748) Bump versions after 9.1.9 release Update branches.json for 9.1.9 release Bump versions after 9.2.3 release Prune changelogs after 8.19.9 release Bump versions after 8.19.9 release Update branches.json for 8.19.9 release Finalize docs for v9.2.3 release (elastic#139795) ESQL: Added timezone support to date_format and date_parse (elastic#138517) Update branches.json for 9.2.3 release Finalize docs for v9.1.9 release (elastic#139796) Switch inline stats to GA in docs (elastic#139753) Validate license in CPS (elastic#139105) FIPS 140-3 support with BC FIPS 2.0.x (elastic#139319) ...
3 participants
TimeZone configurations are snapshot-only, and so is its usage in functions.
Adds timezone handling to DATE_FORMAT and DATE_PARSE.