DataStreamStatsAction can get maxTimestamp from skippers #138158
Conversation
elasticsearchmachine
added
needs:triage
romseygeek
added
>non-issue
:StorageEngine/Logs
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍
Should we also update ReadOnlyEngine#getRawFieldRange(...) to use doc value skippers?
Yes, but I want to do that separately as testing it will be a bit more involved. |
| : new DataStreamOptions.Template(DataStreamFailureStore.builder().enabled(true).buildTemplate()); | ||
| Template idxTemplate = new Template(null, new CompressedXContent(""" | ||
| Settings.Builder settingsBuilder = Settings.builder(); | ||
| if (randomBoolean()) { |
There was a problem hiding this comment.
Up to you, but I'd prefer to have two tests, one for logsdb and one not. I subscribe to the view (there was a discussion on Slack about this) that randomization in tests should be used for stuff you don't care about, whereas in this case we actually care about both cases, and it'd be better if we definitely found out right away if we broke it rather than only having a 50/50 chance.
There was a problem hiding this comment.
Fair point, I'll update.
4 participants
The
@timestampfield in logsdb no longer stores data in a points index,so we need to retrieve the max timestamp field form the docvalues skipper
instead.
Fixes #137208