ESQL: Improve Lookup Join performance with CachedDirectoryReader#137539
Closed
julian-elastic wants to merge 14 commits intoelastic:mainfrom
Closed
ESQL: Improve Lookup Join performance with CachedDirectoryReader#137539julian-elastic wants to merge 14 commits intoelastic:mainfrom
julian-elastic wants to merge 14 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
v9.3.0
needs:triage
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @julian-elastic, I've created a changelog YAML for you. |
Contributor
Author
|
Buildkite benchmark this with esql-joins please |
julian-elastic
commented
Nov 3, 2025
...mpute/src/main/java/org/elasticsearch/compute/operator/lookup/EnrichQuerySourceOperator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Buildkite benchmark this with esql-joins please |
dnhatn
reviewed
Nov 20, 2025
...l/compute/src/main/java/org/elasticsearch/compute/operator/lookup/CachedDirectoryReader.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Buildkite benchmark this with esql-joins please |
julian-elastic
force-pushed
the
CachedDirectoryReader
branch
from
684cc88 to
3e5e9ff
Compare
Contributor
Author
|
Buildkite benchmark this with esql-joins please |
julian-elastic
force-pushed
the
CachedDirectoryReader
branch
from
33d5cf2 to
92dbc74
Compare
Member
|
Buildkite benchmark this with esql-joins please |
Collaborator
|
Hi @julian-elastic, I've updated the changelog YAML for you. |
Contributor
Author
|
Buildkite benchmark this with esql-joins please |
Collaborator
💚 Build Succeeded
This build ran two esql-joins benchmarks to evaluate performance impact of this PR. History |
Contributor
Author
|
Caching docValues to be checked in with #139314, caching termsEnum needs more work. |
Contributor
Author
|
closing this as we are splitting into 2 different PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Lookup Join performance by caching objects needed for Lucene Queries.
We cache DocValues to improve query performance.
Special thanks to @dnhatn for POC and bugfix help for this improvement.
Closes #137268