Skip to content

Exclude some internal, low-level classes from transitive searches for public callers #137193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosche merged 1 commit into from
Oct 28, 2025
Merged

Exclude some internal, low-level classes from transitive searches for public callers #137193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .../java/org/elasticsearch/entitlement/tools/publiccallersfinder/FindUsagesClassVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,25 @@
import java.lang.constant.ClassDesc;
import java.lang.reflect.AccessFlag;
import java.util.EnumSet;
import java.util.Map;
import java.util.Set;

import static java.util.Collections.emptySet;
import static org.objectweb.asm.Opcodes.ACC_PROTECTED;
import static org.objectweb.asm.Opcodes.ACC_PUBLIC;
import static org.objectweb.asm.Opcodes.ASM9;

class FindUsagesClassVisitor extends ClassVisitor {

/**
* Internal classes that should be skipped for further transitive analysis.
*/
private static Map<MethodDescriptor, Set<String>> SKIPS = Map.of(
// heavily used internal low-level APIs used to write bytecode by MethodHandles and similar
new MethodDescriptor("java/nio/file/Files", "write", "(Ljava/nio/file/Path;[B[Ljava/nio/file/OpenOption;)Ljava/nio/file/Path;"),
Set.of("jdk/internal/foreign/abi/BindingSpecializer", "jdk/internal/util/ClassFileDumper")
);

private int classAccess;
private boolean accessibleViaInterfaces;

Expand Down Expand Up @@ -84,6 +95,9 @@ public void visitSource(String source, String debug) {

@Override
public MethodVisitor visitMethod(int access, String name, String descriptor, String signature, String[] exceptions) {
if (SKIPS.getOrDefault(methodToFind, emptySet()).contains(className)) {
return null;
}
return new FindUsagesMethodVisitor(super.visitMethod(access, name, descriptor, signature, exceptions), name, descriptor, access);
}

Expand Down