[ES|QL] Fix assertion error after inference resolution.#134777
Merged
afoucret merged 3 commits intoelastic:mainfrom Sep 17, 2025
Merged
[ES|QL] Fix assertion error after inference resolution.#134777afoucret merged 3 commits intoelastic:mainfrom
afoucret merged 3 commits intoelastic:mainfrom
Conversation
The error has been introduced in elastic#132324 Now making sure that InferenceResolver answer though the SEARCH_COORDINATION threadpool so subsequent assertions will not fail.
afoucret
added
>non-issue
v9.2.0
:Search Relevance/ES|QL
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ioanatia
approved these changes
Sep 16, 2025
Contributor
|
the changes look good - pulled your branch too to test it - looks good! |
Contributor
That is the change that discovered the error, not introduced it. Could you please share what thread pool the result was forked too before this change? |
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/inference/InferenceResolver.java
Show resolved
Hide resolved
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
The error has been introduced in elastic#132324 Now making sure that InferenceResolver answer though the SEARCH_COORDINATION threadpool so subsequent assertions will not fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error has been introduced in #132324
Now making sure that InferenceResolver answer though the SEARCH_COORDINATION thread pool so subsequent assertions will not fail.