Skip to content

Optimize TSDBDocValuesFormat's prefix sum a bit.#134204

Merged
jpountz merged 2 commits intoelastic:mainfrom
jpountz:optimize_tsdb_prefix_sum
Sep 9, 2025
Merged

Optimize TSDBDocValuesFormat's prefix sum a bit.#134204
jpountz merged 2 commits intoelastic:mainfrom
jpountz:optimize_tsdb_prefix_sum

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented Sep 5, 2025

Benchmarks at apache/lucene#14979 suggested that tracking the sum in a variable performs faster than adding the previous value to each array element.

Benchmarks at apache/lucene#14979 suggested that
tracking the sum in a variable performs faster than adding the previous value
to each array element.
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.2.0 labels Sep 5, 2025
@jpountz jpountz added :StorageEngine/TSDB You know, for Metrics and removed needs:triage Requires assignment of a team area label v9.2.0 labels Sep 5, 2025
@jpountz jpountz requested a review from dnhatn September 5, 2025 09:05
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Adrien!

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpountz jpountz merged commit 34fd42d into elastic:main Sep 9, 2025
34 checks passed
@jpountz jpountz deleted the optimize_tsdb_prefix_sum branch September 9, 2025 08:35
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Sep 9, 2025
Benchmarks at apache/lucene#14979 suggested that
tracking the sum in a variable performs faster than adding the previous value
to each array element.
Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Sep 9, 2025
Benchmarks at apache/lucene#14979 suggested that
tracking the sum in a variable performs faster than adding the previous value
to each array element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants