Add XContentParserTsidFunnel#133457
Merged
felixbarny merged 2 commits intoelastic:mainfrom Aug 25, 2025
Merged
Conversation
elasticsearchmachine
added
needs:triage
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
elasticsearchmachine
removed
the
needs:triage
3 tasks
kkrik-es
reviewed
Aug 25, 2025
| /** | ||
| * A funnel that extracts dimensions from an {@link XContentParser} and adds them to a {@link TsidBuilder}. | ||
| */ | ||
| class XContentParserTsidFunnel implements TsidBuilder.ThrowingTsidFunnel<XContentParser, IOException> { |
Contributor
There was a problem hiding this comment.
There's duplication with IndexRouting.ExtractFromSource.Builder. Consider deduplicating the logic, here or in a follow-up.
Member
Author
There was a problem hiding this comment.
There are some subtle differences that make abstracting this difficult. For example, we're using the string representation for numbers and booleans when creating a routing_path-based hash. This isn't ideal from a performance perspective but changing that for routing_path would be a breaking change. I'll merge as-is for now and we can discuss whether creating some kind of abstraction for this would still make sense given the differences.
kkrik-es
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #132566