Skip to content

Don't fail search if bottom doc can't be formatted#133188

Merged
smalyshev merged 4 commits intoelastic:mainfrom
smalyshev:fix-shard-failure-on-bottom-docs
Aug 20, 2025
Merged

Don't fail search if bottom doc can't be formatted#133188
smalyshev merged 4 commits intoelastic:mainfrom
smalyshev:fix-shard-failure-on-bottom-docs

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Aug 19, 2025

Closes #125321

@smalyshev smalyshev requested a review from jimczi August 19, 2025 23:28
@smalyshev smalyshev added >bug :Search Foundations/Search Catch all for Search Foundations auto-backport Automatically create backport pull requests when merged v9.1.3 v8.19.3 v8.18.6 labels Aug 19, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 19, 2025

Hi @smalyshev, I've created a changelog YAML for you.

@smalyshev smalyshev marked this pull request as ready for review August 19, 2025 23:50
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 19, 2025

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Aug 19, 2025
jimczi
jimczi approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev smalyshev merged commit 84443ee into elastic:main Aug 20, 2025
34 checks passed
@smalyshev smalyshev mentioned this pull request Aug 20, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 20, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
✅ 9.1
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 133188

smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 20, 2025
@smalyshev
Don't fail search if bottom doc can't be formatted (elastic#133188)
8b4b9b5 
* Don't fail search if bottom doc can't be formatted
elasticsearchmachine pushed a commit that referenced this pull request Aug 20, 2025
@smalyshev
Don't fail search if bottom doc can't be formatted (#133188) (#133230)
88facdd 
* Don't fail search if bottom doc can't be formatted
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 20, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into geoip-enrich-cache-…
b810b0d 
…improv

* upstream/main: (58 commits)
  Fixing flaky LoggedExec (tests) (elastic#133215)
  CPS search should not use `skip_unavailable` (elastic#132927)
  Don't fail search if bottom doc can't be formatted (elastic#133188)
  Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupByNothing elastic#133225
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedSetDocValuesWithSkipperSmall elastic#133224
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedNumberMergeAwayAllValuesWithSkipper elastic#133223
  Adding support for index.number_of_replicas to data stream settings (elastic#132748)
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedDocValuesSingleUniqueValue elastic#133221
  Fix VectorSimilarityFunctionsIT (elastic#133206)
  Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupBySubset elastic#133220
  Increase the number of FORK branches in ForkGenerator (elastic#132019)
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=STORED]} elastic#133218
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=DOC_VALUES]} elastic#133217
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=NONE]} elastic#133216
  Set default processor allocation for test clusters (elastic#133204)
  Add mapper for exponential histograms (elastic#132493)
  Fix offset handling in Murmur3Hasher (elastic#133193)
  unmute testDoesNotResolveClosedIndex (elastic#133115)
  Fix an AWS SDK v2 release note (elastic#133155)
  Limit the depth of a filter (elastic#133113)
  ...
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 20, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into invalid-grok-500
e204957 
* upstream/main: (58 commits)
  Fixing flaky LoggedExec (tests) (elastic#133215)
  CPS search should not use `skip_unavailable` (elastic#132927)
  Don't fail search if bottom doc can't be formatted (elastic#133188)
  Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupByNothing elastic#133225
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedSetDocValuesWithSkipperSmall elastic#133224
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedNumberMergeAwayAllValuesWithSkipper elastic#133223
  Adding support for index.number_of_replicas to data stream settings (elastic#132748)
  Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedDocValuesSingleUniqueValue elastic#133221
  Fix VectorSimilarityFunctionsIT (elastic#133206)
  Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupBySubset elastic#133220
  Increase the number of FORK branches in ForkGenerator (elastic#132019)
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=STORED]} elastic#133218
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=DOC_VALUES]} elastic#133217
  Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=NONE]} elastic#133216
  Set default processor allocation for test clusters (elastic#133204)
  Add mapper for exponential histograms (elastic#132493)
  Fix offset handling in Murmur3Hasher (elastic#133193)
  unmute testDoesNotResolveClosedIndex (elastic#133115)
  Fix an AWS SDK v2 release note (elastic#133155)
  Limit the depth of a filter (elastic#133113)
  ...
@smalyshev smalyshev mentioned this pull request Aug 20, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 20, 2025
@smalyshev
Don't fail search if bottom doc can't be formatted (elastic#133188)
f3113e0 
* Don't fail search if bottom doc can't be formatted

(cherry picked from commit 84443ee)

# Conflicts:
#	server/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java
@smalyshev smalyshev mentioned this pull request Aug 20, 2025
Merged
@smalyshev
Copy link
Contributor Author

smalyshev commented Aug 20, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 20, 2025
@smalyshev
Don't fail search if bottom doc can't be formatted (elastic#133188)
cbaa2d0 
* Don't fail search if bottom doc can't be formatted

(cherry picked from commit 84443ee)

# Conflicts:
#	server/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java
@smalyshev smalyshev deleted the fix-shard-failure-on-bottom-docs branch August 20, 2025 17:40
elasticsearchmachine pushed a commit that referenced this pull request Aug 20, 2025
@smalyshev
[8.19] Don't fail search if bottom doc can't be formatted (#133188) (#…
a6b9b65 
…133243)

* Don't fail search if bottom doc can't be formatted (#133188)

* Don't fail search if bottom doc can't be formatted

(cherry picked from commit 84443ee)

# Conflicts:
#	server/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java

* Fix test
elasticsearchmachine pushed a commit that referenced this pull request Aug 20, 2025
@smalyshev
[8.18] Don't fail search if bottom doc can't be formatted (#133188) (#…
0c1ed50 
…133244)

* Don't fail search if bottom doc can't be formatted (#133188)

* Don't fail search if bottom doc can't be formatted

(cherry picked from commit 84443ee)

# Conflicts:
#	server/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java

* [CI] Auto commit changes from spotless

* fix test

* fix imports

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimczi jimczi jimczi approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.18.6 v8.19.3 v9.1.3 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arithmetic exception when sort by date field

3 participants

@smalyshev @elasticsearchmachine @jimczi