Split transport version func test into abstract base#133035
Merged
rjernst merged 2 commits intoelastic:mainfrom Aug 19, 2025
Merged
Split transport version func test into abstract base#133035rjernst merged 2 commits intoelastic:mainfrom
rjernst merged 2 commits intoelastic:mainfrom
Conversation
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
rjernst
added
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
JVerwolf
approved these changes
Aug 18, 2025
Contributor
JVerwolf
left a comment
JVerwolf
left a comment
There was a problem hiding this comment.
I think it would be more clear to have ids defined in the tests that use them, but I won't block on it as this is easy enough to clean up later.
| apply plugin: 'elasticsearch.transport-version-references' | ||
| apply plugin: 'elasticsearch.transport-version-resources' | ||
| """ | ||
| namedTransportVersion("existing_91", "8012000") |
Contributor
There was a problem hiding this comment.
These TVs are specific to the transport version tests, WDYT about moving them to a setup() method there?
Member
Author
There was a problem hiding this comment.
They aren't specific to validation, they're a basic setup for all transport version tests, so i think they belong here. A test for generation would also need this basic setup of some named versions and latest files.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
This was referenced Aug 19, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
This was referenced Aug 19, 2025
Collaborator
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 19, 2025
…improv * upstream/main: (92 commits) ESQL: mark LOOKUP JOIN as ExecutesOn.Any by default (elastic#133064) Fix 404s in REST API landing page (elastic#133086) Fix release tests for OptimizerVerificationTests (elastic#133100) Make Glob non-recursive (elastic#132798) Update ES|QL function list for release versions (elastic#133096) Split transport version func test into abstract base (elastic#133035) Omit project ID from snapshot metrics (elastic#133098) Mute org.elasticsearch.xpack.esql.analysis.AnalyzerTests testNoDenseVectorFailsForMagnitude elastic#133013 Mute org.elasticsearch.xpack.esql.optimizer.OptimizerVerificationTests testRemoteEnrichAfterCoordinatorOnlyPlans elastic#133015 Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/160_exists_query/Test exists query on _id field} elastic#133097 Rename initial to unreferenced in transport versions (elastic#133082) Rename exception type header (elastic#133045) ESQL: Pluggable tests for Operator status (elastic#132876) ESQL: Mark new signatures in MIN and MAX (elastic#132980) Don't try to serialize half-baked cluster info (elastic#132756) migrate ml_rollover_legacy_indices transport version (elastic#133008) Enable `exclude_source_vectors` by default for new indices (elastic#131907) Expose APIs needed by flush during translog replay (elastic#132960) Change reporting_user role to leverage reserved kibana privileges (elastic#132766) Update TasksIT for batched execution (elastic#132762) ...
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 19, 2025
* upstream/main: (58 commits) ESQL: mark LOOKUP JOIN as ExecutesOn.Any by default (elastic#133064) Fix 404s in REST API landing page (elastic#133086) Fix release tests for OptimizerVerificationTests (elastic#133100) Make Glob non-recursive (elastic#132798) Update ES|QL function list for release versions (elastic#133096) Split transport version func test into abstract base (elastic#133035) Omit project ID from snapshot metrics (elastic#133098) Mute org.elasticsearch.xpack.esql.analysis.AnalyzerTests testNoDenseVectorFailsForMagnitude elastic#133013 Mute org.elasticsearch.xpack.esql.optimizer.OptimizerVerificationTests testRemoteEnrichAfterCoordinatorOnlyPlans elastic#133015 Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/160_exists_query/Test exists query on _id field} elastic#133097 Rename initial to unreferenced in transport versions (elastic#133082) Rename exception type header (elastic#133045) ESQL: Pluggable tests for Operator status (elastic#132876) ESQL: Mark new signatures in MIN and MAX (elastic#132980) Don't try to serialize half-baked cluster info (elastic#132756) migrate ml_rollover_legacy_indices transport version (elastic#133008) Enable `exclude_source_vectors` by default for new indices (elastic#131907) Expose APIs needed by flush during translog replay (elastic#132960) Change reporting_user role to leverage reserved kibana privileges (elastic#132766) Update TasksIT for batched execution (elastic#132762) ...
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support future gradle transport version tests, this commit adds a base abstract case with setup and utilities for managing transport version resources. It also renames the existing func test to make it more clear it is aimed at testing transport version validation.