Merged
Conversation
joegallo
added
>non-issue
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been in this code for a few weeks, and I've collected up a bunch of pretty trivial cleanups and gripes into this single cleanup PR. There's almost nothing here that a person should review (by lines of code changed it's mostly changes to comments and fussing about with collections code).
I do think the buglet in 1145674 is worth looking at, though -- I'm pretty sure I'm implementing what was originally intended to be there, but take a look and see if you agree.
Note: I've added @tvernum as a reviewer just as an FYI to him that this PR exists, I don't actually need his +1 specifically (anybody the @elastic/es-security team is fine by me).