ESQL: Remove removed param from EsqlSpec argument formatting#132256
ESQL: Remove removed param from EsqlSpec argument formatting#132256nik9000 merged 1 commit intoelastic:mainfrom
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
On one side this will not open 2 failures (for SYNC and for ASYNC) when the test fails, on the other side I am wondering if it might be important for us to know in what mode has failure happened? Can we reproduce the mode with the seed? |
|
@idegtiarenko In theory, yes, the seed should be enough. The mode is now calculated with a random() here: https://github.com/elastic/elasticsearch/pull/131949/files#diff-e5229c7428590a22294db189f7845ae0fadefc37b2154c5da1f1dc85804bcaecR121 |
The seed should be enough, yeah. |
Fix after #131949
Initially, the test string was:
test {file.test SYNC/ASYNC}After the mentioned PR:
test {file.test [ABC0ABCA0:ABC0ABC0]}With this fix:
test {file.test}