Merged
Conversation
eyalkoren
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
jdconrad
approved these changes
Jul 30, 2025
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Jul 31, 2025
Test was removed in elastic#132063, so we can remove the mutes and close the test failure issue. Closes elastic#131803
Merged
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 1, 2025
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Aug 1, 2025
Test was removed in elastic#132063, so we can remove the mutes and close the test failure issue. Closes elastic#131803 (cherry picked from commit eea9144) # Conflicts: # muted-tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mark-vieira I (naively) added this test in #131583 in addition to removing the broken test. This caused another issue due to the usage of a synthetic future version.
In order to fix it now we can add a test cluster feature to
8.19, even though the feauture is not backported, just so we can use it to limit where the test runs instead of the version (as I did in the new test I added tomain), but this is weird and seems like an awful overkill.I think the best thing to do now is remove this test altogether. The usage of wrong
data_stream.typeis still tested for the other two types (and it's not as if we test to all possible types anyway). In addition, this doesn't really verifies compatibility.