Build Tasks to Find and Verify TransportVersion Definitions by JVerwolf · Pull Request #131782 · elastic/elasticsearch

JVerwolf · 2025-07-23T18:49:14Z

This PR introduces a set of build tasks to find and verify TransportVersion definitions using the new model.

This includes:

A task to locate all transport version declarations of the form TransportVersion.fromName("some_name");, and record all the String literal arguments in a build file.
A task to verify that all TransportVersion declarations have a corresponding data file
A task to verify that all TransportVersion data files have a corresponding declaration
A task to produce a manifest file that contains the filenames of all data files, for later use in a getResources call.

A subsequent PR will introduce a task to generate the data files.

Jiras:
ES-12335
ES-12336
ES-12398
ES-12338

...java/org/elasticsearch/gradle/internal/transport/GlobalTransportVersionManagementPlugin.java

.../main/java/org/elasticsearch/gradle/internal/transport/TransportVersionManagementPlugin.java

.../java/org/elasticsearch/gradle/internal/transport/CollectTransportVersionReferencesTask.java

.../main/java/org/elasticsearch/gradle/internal/transport/TransportVersionManagementPlugin.java

.../java/org/elasticsearch/gradle/internal/transport/CollectTransportVersionReferencesTask.java

...java/org/elasticsearch/gradle/internal/transport/GlobalTransportVersionManagementPlugin.java

elasticsearchmachine · 2025-07-29T23:27:15Z

Pinging @elastic/es-core-infra (Team:Core/Infra)

elasticsearchmachine · 2025-07-29T23:27:16Z

Pinging @elastic/es-delivery (Team:Delivery)

jdconrad · 2025-07-30T23:31:50Z

@elasticmachine run elasticsearch-ci/bwc-snapshots-part3

jdconrad

LGTM!

elasticsearchmachine · 2025-08-01T19:11:33Z

💔 Backport failed

Status	Branch	Result
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	9.1	Commit could not be cherrypicked due to conflicts
❌	8.19	Commit could not be cherrypicked due to conflicts
❌	9.0	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131782

…cking * upstream/main: (166 commits) Reduce inactive sink interval in VectorSimilarityFunctionsIT (elastic#132288) ESQL: Allow agg tests to process many columns (elastic#132358) Update analysis-lowercase-tokenfilter.md (elastic#132359) Add Sparse Vector Index Options Settings to Semantic Text Field (elastic#131058) Collect node thread pool usage for shard balancing (elastic#131480) Add tasks to validate new style transport versions (elastic#131782) Mute org.elasticsearch.search.routing.SearchReplicaSelectionIT testNodeSelection elastic#132354 Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryIT testBadAsyncId elastic#132353 Fixes DenseVectorFieldIndexTypeUpdateIT release tests (elastic#132346) Fix testCloseOrReallocateDuringPartialSnapshot (elastic#132049) (Doc) ILM Force Merge not on HDD and happens on hosting node not current phase tier (elastic#130280) Run GeoIp YAML tests in multi-project cluster and fix bug discovered by tests (elastic#131521) Unmutes elastic#132111, seems a transient, non reproducible issue (elastic#132253) Mute org.elasticsearch.search.suggest.phrase.PhraseSuggesterIT testPhraseSuggestionWithNgramOnlyAnalyzerThrowsException elastic#132347 Add AI21 support to Inference Plugin (elastic#131238) OpenJDK EA builds should use https instead of http (elastic#132297) ESQL: Normalize timeseries aggs slightly (elastic#132284) Avoid internal server error on suggester ngram bad request (elastic#132321) [ES|QL] Rerank operator improvements (elastic#132318) Mute org.elasticsearch.xpack.logsdb.qa.LogsDbVersusReindexedLogsDbChallengeRestIT testTermsQuery elastic#132337 ...

This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions. Co-authored-by: Ryan Ernst <ryan@iernst.net> Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com>

This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions. Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com>

* Add tasks to validate new style transport versions (#131782) This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions. Co-authored-by: Ryan Ernst <ryan@iernst.net> Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com> * skip if no named constants yet * [CI] Auto commit changes from spotless * don't actually set it if it doesn't exist --------- Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

* Add tasks to validate new style transport versions (#131782) This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions. Co-authored-by: Ryan Ernst <ryan@iernst.net> Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com> * skip if no named constants yet * [CI] Auto commit changes from spotless * temporarily add leniency for definitions dir * [CI] Auto commit changes from spotless --------- Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions. Co-authored-by: John Verwolf <JVerwolf@users.noreply.github.com>

Add task to scan for TV instantiations

57193ca

elasticsearchmachine added the v9.2.0 label Jul 23, 2025

JVerwolf and others added 9 commits July 24, 2025 11:26

Initial draft

de27ca3

wip

68dbac8

Merge branch 'main' into new-tv-logic-locate-declaration

6071cdf

add example

312235e

[CI] Auto commit changes from spotless

818bda4

iter

1721d2e

iter and add generate manifest

8c8c7c4

wired manifest task

3d30062

done

d945947

JVerwolf changed the title ~~[WIP] Add task to scan for TV instantiations~~ Build Tasks to Find and Verify TransportVersion Definitions Jul 25, 2025

spotless and rename

c6251da

JVerwolf requested a review from a team July 25, 2025 20:41

moved to defined

97503ab

JVerwolf added auto-backport Automatically create backport pull requests when merged v8.18.0 v9.1.1 labels Jul 25, 2025

JVerwolf requested a review from mark-vieira July 25, 2025 20:43

JVerwolf added v9.0.5 v8.19.1 >enhancement labels Jul 25, 2025

JVerwolf marked this pull request as ready for review July 25, 2025 20:45

JVerwolf requested a review from a team as a code owner July 25, 2025 20:45

elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 25, 2025

fix task name

508aec1

mark-vieira reviewed Jul 25, 2025

View reviewed changes

rjernst added 3 commits July 25, 2025 15:39

address review comments

1e3fb65

iter

49dca33

more feedback

a4c62df

rjernst added >refactoring :Delivery/Build Build or test infrastructure and removed >enhancement labels Jul 29, 2025

elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Jul 29, 2025

rjernst added 2 commits July 30, 2025 12:42

remove constants

3dd41ff

Merge branch 'main' into new-tv-logic-locate-declaration

252f9c7

elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jul 31, 2025

rjernst added 6 commits July 31, 2025 07:49

Merge branch 'main' into new-tv-logic-locate-declaration

df07e02

make definitions dir optional for validation

3c465d4

better reference checker

6821e70

Merge branch 'main' into new-tv-logic-locate-declaration

c184989

try again

aa14965

guard global plugin too

1e9a4ec

jdconrad approved these changes Aug 1, 2025

View reviewed changes

rjernst merged commit 4856d35 into elastic:main Aug 1, 2025
33 checks passed

elasticsearchmachine added the backport pending label Aug 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Build Tasks to Find and Verify TransportVersion Definitions#131782

Build Tasks to Find and Verify TransportVersion Definitions#131782
rjernst merged 27 commits intoelastic:mainfrom
JVerwolf:new-tv-logic-locate-declaration

JVerwolf commented Jul 23, 2025 •

edited by atlassian bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 29, 2025

Uh oh!

elasticsearchmachine commented Jul 29, 2025

Uh oh!

jdconrad commented Jul 30, 2025

Uh oh!

jdconrad left a comment

Uh oh!

Uh oh!

elasticsearchmachine commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

JVerwolf commented Jul 23, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 29, 2025

Uh oh!

elasticsearchmachine commented Jul 29, 2025

Uh oh!

jdconrad commented Jul 30, 2025

Uh oh!

jdconrad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticsearchmachine commented Aug 1, 2025

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JVerwolf commented Jul 23, 2025 •

edited by atlassian bot

Loading