Grant server read/write permissions on shared data path "path.shared_data". by mosche · Pull Request #131680 · elastic/elasticsearch

mosche · 2025-07-22T10:12:47Z

Grant server read/write permissions on missing shared data path "path.shared_data".
This setting is deprecated, but possibly still used. This surfaced when enabling entitlements in internalClusterTest.

Relates to ES-12447

…data". Relates to ES-12447

elasticsearchmachine · 2025-07-22T10:13:23Z

Pinging @elastic/es-core-infra (Team:Core/Infra)

elasticsearchmachine · 2025-07-22T10:14:04Z

Hi @mosche, I've created a changelog YAML for you.

rjernst

LGTM

rjernst

Can you also check there is a qa test that actually uses shared data, so that we are sure the permission granted to server is sufficient?

mosche · 2025-07-22T14:41:16Z

There's lots of internalClusterTests using it, that's how i noticed this is missing. No QA rest tests though.
I tried testing locally, but couldn't figure out how this get's used and there's not much docs around it.
Happy to write a QA test if you could provide some pointers.

rjernst · 2025-07-22T17:48:53Z

A rest test (java or yaml, doesn't matter) would be good as that is more realistic than an internalClusterTest. But if there are some tests already it doesn't need to block this PR, adding additional testing could be a followup.

elasticsearchmachine · 2025-07-23T08:43:09Z

💔 Backport failed

Status	Branch	Result
❌	9.0	Commit could not be cherrypicked due to conflicts
❌	9.1	Commit could not be cherrypicked due to conflicts
❌	8.19	Commit could not be cherrypicked due to conflicts
❌	8.18	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131680

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java # server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java # test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java # libs/entitlement/src/test/java/org/elasticsearch/entitlement/runtime/policy/PolicyManagerTests.java # server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java # test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java

mosche · 2025-07-24T15:08:40Z

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	9.0
✅	8.19
✅	8.18

Questions ?

Please refer to the Backport tool documentation

…data". (#131680) (#131849) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java # server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java # test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java

…data". (#131680) (#131847) Relates to ES-12447 (cherry picked from commit d16eb70)

…data". (#131680) (#131850) Relates to ES-12447 (cherry picked from commit d16eb70)

…data". (#131680) (#131851) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java # libs/entitlement/src/test/java/org/elasticsearch/entitlement/runtime/policy/PolicyManagerTests.java # server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java # test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

Grant server read/write permissions on shared data path "path.shared_…

35d7a24

…data". Relates to ES-12447

mosche requested a review from a team as a code owner July 22, 2025 10:12

mosche added >bug :Core/Infra/Entitlements Entitlements infrastructure labels Jul 22, 2025

elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 22, 2025

mosche added auto-backport Automatically create backport pull requests when merged v9.0.2 v9.1.1 v8.19.1 v9.0.5 v8.18.5 and removed Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 22, 2025

elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 22, 2025

mosche and others added 2 commits July 22, 2025 12:14

Update docs/changelog/131680.yaml

90ef9a3

fix

b681afe

mosche force-pushed the entitlements/shared_data_path branch from ef543ec to b681afe Compare July 22, 2025 11:02

rjernst approved these changes Jul 22, 2025

View reviewed changes

rjernst reviewed Jul 22, 2025

View reviewed changes

mosche merged commit d16eb70 into elastic:main Jul 23, 2025
34 checks passed

elasticsearchmachine added the backport pending label Jul 23, 2025

mosche added v9.2.0 and removed v9.0.2 labels Jul 23, 2025

mosche mentioned this pull request Jul 23, 2025

Grant file entitlements for shared data dir to ES base due to lack of entitlement delegation #131748

Merged

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025

Grant server read/write permissions on shared data path "path.shared_…

c2fc039

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025

Grant server read/write permissions on shared data path "path.shared_…

89c84da

…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)

mosche mentioned this pull request Jul 24, 2025

[8.18] Grant server read/write permissions on shared data path "path.shared_data". (#131680) #131851

Merged

elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025

Grant server read/write permissions on shared data path "path.shared_…

a80b094

…data". (#131680) (#131847) Relates to ES-12447 (cherry picked from commit d16eb70)

elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025

Grant server read/write permissions on shared data path "path.shared_…

b8ccad7

…data". (#131680) (#131850) Relates to ES-12447 (cherry picked from commit d16eb70)

mosche added a commit that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (#131748)

ab7bd9b

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (elastic#131748)

d90d8f9

This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (elastic#131748)

114282f

This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (elastic#131748)

908113d

This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (elastic#131748)

df65155

This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.

elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (#131748) (#132059)

c11f79d

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (#131748) (#132058)

9804bad

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (#131748) (#132061)

7f9d90f

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025

Fix file entitlements for shared data dir (#131748) (#132060)

31cad16

This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.

mosche removed the backport pending label Nov 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grant server read/write permissions on shared data path "path.shared_data".#131680

Grant server read/write permissions on shared data path "path.shared_data".#131680
mosche merged 3 commits intoelastic:mainfrom
mosche:entitlements/shared_data_path

mosche commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

rjernst left a comment

Uh oh!

rjernst left a comment

Uh oh!

mosche commented Jul 22, 2025

Uh oh!

rjernst commented Jul 22, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 23, 2025

Uh oh!

mosche commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mosche commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

rjernst left a comment

Choose a reason for hiding this comment

Uh oh!

rjernst left a comment

Choose a reason for hiding this comment

Uh oh!

mosche commented Jul 22, 2025

Uh oh!

rjernst commented Jul 22, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 23, 2025

💔 Backport failed

Uh oh!

mosche commented Jul 24, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants