Skip to content

Comments

Only use test-error-query in snapshot builds#131134

Merged
smalyshev merged 7 commits intoelastic:mainfrom
smalyshev:fix-130978
Jul 23, 2025
Merged

Only use test-error-query in snapshot builds#131134
smalyshev merged 7 commits intoelastic:mainfrom
smalyshev:fix-130978

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Jul 11, 2025

Fixes #130978

@smalyshev smalyshev requested a review from mark-vieira July 11, 2025 22:59
@smalyshev smalyshev added :Search Foundations/Search Catch all for Search Foundations >test Issues or PRs that are addressing/adding tests labels Jul 11, 2025
@mark-vieira
Copy link
Contributor

You'll want to add the test-release label to actually test this in release builds. We don't run those tests by default on pull requests.

@mark-vieira mark-vieira added the test-release Trigger CI checks against release build label Jul 14, 2025
@smalyshev
Copy link
Contributor Author

You'll want to add the test-release label to actually test this in release builds

Today I learned! Thanks!

@smalyshev smalyshev marked this pull request as ready for review July 14, 2025 18:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 14, 2025
@javanna
Copy link
Contributor

javanna commented Jul 15, 2025

Thanks for following up on this @smalyshev !

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I find it somewhat confusing that the tests pass w/o the plugin installed. I guess they are disabled in non-snapshot builds elsewhere?

@smalyshev
Copy link
Contributor Author

@mark-vieira yes, they should be disabled by either individual or class-level assumeTrues if they need snapshot functionality.

@smalyshev smalyshev enabled auto-merge (squash) July 22, 2025 23:19
@smalyshev smalyshev merged commit 7001fcc into elastic:main Jul 23, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] AsyncSearchSecurityIT class failing

4 participants