Remove 'index' from snapshot clear_cache query params#131067
Merged
pquentin merged 4 commits intoelastic:mainfrom Jul 17, 2025
Merged
Remove 'index' from snapshot clear_cache query params#131067pquentin merged 4 commits intoelastic:mainfrom
pquentin merged 4 commits intoelastic:mainfrom
Conversation
It's already part of the path parts, it's not useful to duplicate it in query parameters.
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
25 tasks
This was referenced Jul 17, 2025
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query parameters.
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query parameters.
This was referenced Jul 17, 2025
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query parameters.
Collaborator
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query parameters.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's already part of the path parts, it's not useful to duplicate it in query parameters. (All path parts can be query parameters, but we don't usually duplicate them.)
However, if it's considered a bad idea, I can adjust the Elasticsearch specification instead.