Remove deprecated function isNotNullAndFoldable #130944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-elastic
commented
Jul 14, 2025
...k/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Knn.java
Show resolved
Hide resolved
julian-elastic
commented
Jul 14, 2025
...k/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Knn.java
Outdated
Show resolved
Hide resolved
julian-elastic
commented
Jul 17, 2025
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Show resolved
Hide resolved
elasticsearchmachine
removed
the
needs:triage
julian-elastic
changed the title
Collaborator
|
Hi @julian-elastic, I've updated the changelog YAML for you. |
|
💚 CLA has been signed |
julian-elastic
changed the title
Collaborator
|
Hi @julian-elastic, I've updated the changelog YAML for you. |
nik9000
reviewed
Jul 22, 2025
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Top.java
Show resolved
Hide resolved
nik9000
reviewed
Jul 23, 2025
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Looks great! I have a question about how you build the new validator thing. I'm quite happy though.
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/FunctionUtils.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/FunctionUtils.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/FunctionUtils.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/FunctionUtils.java
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Top.java
Outdated
Show resolved
Hide resolved
nik9000
approved these changes
Jul 24, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 25, 2025
…king * upstream/main: (90 commits) Register a blob cache long counter metric for total evicted regions (elastic#131862) Move plan attribute resolution to its own component (elastic#131830) Make restore support multi-project (elastic#131661) Use logically more correct expression (elastic#131869) [ES|QL] Change equals and hashcode for ConstantNullBlock (elastic#131817) Update `TransportVersion` to support a new model (elastic#131488) Correct slow log user for RCS 2.0 (elastic#130140) Revert "Remove 8.17 from dev branches" Mute org.elasticsearch.compute.aggregation.ValuesBytesRefGroupingAggregatorFunctionTests testSomeFiltered elastic#131878 Remove 8.17 from dev branches Revert "CompressorFactory.compressor (elastic#131655)" (elastic#131866) Add fast path for single value in VALUES aggregator (elastic#130510) Resolve inference release tests failing due to missing feature flag (elastic#131841) [Docs] Replace placeholder URLs (elastic#131309) CompressorFactory.compressor (elastic#131655) add availability info for speed loading setting (elastic#131714) [Logstash] Move `elastic_integration` plugin usage to ES logstash-bridge. (elastic#131486) Migrate x-pack-enrich legacy rest tests to new test framework (elastic#131743) Fix plugin example test failures due to deprecation warning (elastic#131819) Remove deprecated function isNotNullAndFoldable (elastic#130944) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated function isNotNullAndFoldable.
It was getting called in the TypeResolution for various functions.
With the change, we still check the isNotNull part during TypeResolution. However, a lot of the other checks are moved to postOptimizationVerification(), that happens after the constant have been folded during normal logical planning.
Resolves #119756
However, it seems that there are still a few places we do folding outside logical planning. They are marked with /* TODO remove me */ and will be handled in a separate PR