Fix NPE when date_buckets aggregation is missing in the response
#128974
Conversation
przemekwitek
added
:ml
|
Pinging @elastic/ml-core (Team:ML) |
| List<? extends Histogram.Bucket> buckets = ((Histogram) response.getAggregations().get(DATE_BUCKETS)).getBuckets(); | ||
| Histogram histogram = searchResponse.getAggregations().get(DATE_BUCKETS); | ||
| if (histogram == null) { | ||
| logger.debug( |
There was a problem hiding this comment.
We expect this to be a rare occurrence so let's log it at a higher level. Also we want to know if the delayed detector is not working
| logger.debug( | |
| logger.warn( |
There was a problem hiding this comment.
Just double-checking: If we log at WARN, we shouldn't include full request/response bodies, should we?
There was a problem hiding this comment.
hmm probably not, we know what the request is anyway as it's fixed in code.
There was a problem hiding this comment.
On a second thought, I added logging of "search response" because if the agg is missing, the response is never big and we can get more useful info this way.
...n/java/org/elasticsearch/xpack/ml/datafeed/delayeddatacheck/DatafeedDelayedDataDetector.java
Outdated
Show resolved
Hide resolved
|
Hi @przemekwitek, I've created a changelog YAML for you. |
|
run elasticsearch-ci/part-2 |
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM thanks for making the changes
przemekwitek
added
the
auto-backport
💔 Backport failedYou can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
3 participants
This PR fixes NPE thrown by the
DatafeedDelayedDataDetector.checkCurrentBucketEventCountmethod when thedate_bucketsaggregation is missing in the response.