Enable security in a number of logsdb and tsdb integration tests. #128877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables security in a number of tsdb and logsdb integration tests. A number of java/yaml rest tests in logsdb module, additionally logsdb and tsdb rolling upgrade tests. A recent bug (elastic#128050) wouldn't have happened if logsdb rolling upgrade tests ran with security enabled.
martijnvg
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Jun 4, 2025
|
|
||
| if (oldVersion.before(Version.fromString("8.18.0"))) { | ||
| cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper"); | ||
| cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService"); |
Contributor
There was a problem hiding this comment.
Why do we need these? Maybe add a comment?
Member
Author
There was a problem hiding this comment.
I just copied this from the other base class. We added that there because an assertion would fail when index was created on older version. This was regarding mode _source meta field mapper, which wouldn't always exist.
kkrik-es
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables security in a number of java/yaml rest tests in logsdb module, additionally logsdb and tsdb rolling upgrade tests.
A recent bug (#128050) wouldn't have happened if logsdb rolling upgrade tests ran with security enabled.