-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Support DATE_NANOS in LOOKUP JOIN #127962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
craigtaverner
merged 23 commits into
elastic:main
from
craigtaverner:lookup_join_date_nanos
Jun 4, 2025
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7fcb1d6
WIP Start supporting DATE_NANOS in LOOKUP JOIN
craigtaverner 68aaa6d
Update docs/changelog/127962.yaml
craigtaverner 9c13833
Update docs/changelog/127962.yaml
craigtaverner 657f1c0
Possible solution with passing tests
craigtaverner 5592bb5
Merge branch 'main' into lookup_join_date_nanos
craigtaverner 23bf41a
Use lookup-prefix index name to avoid clash with union-types tests
craigtaverner b9a7134
More correct date_nanos support by minimizing date rendering and parsing
craigtaverner 9a582f9
Merge remote-tracking branch 'origin/main' into lookup_join_date_nanos
craigtaverner bb81b8a
Improved solution, rather have date parsing entirely skipped in DateF…
craigtaverner adf53f9
Merge remote-tracking branch 'origin/main' into lookup_join_date_nanos
craigtaverner 71b056f
Add EsqlCapabilities to block csv-spec tests in mixed clusters
craigtaverner f211158
Make csv-spec test multi-node and serverless safe with a SORT
craigtaverner b906e3f
Merge remote-tracking branch 'origin/main' into lookup_join_date_nanos
craigtaverner dd39363
Merge branch 'main' into lookup_join_date_nanos
craigtaverner 9c02a93
Merge branch 'main' into lookup_join_date_nanos
craigtaverner fd01818
After merging with main, fixed compile error
craigtaverner e5cdf7c
Reverted temporary change
craigtaverner cfbfecd
Merge branch 'main' into lookup_join_date_nanos
craigtaverner 31d0375
Add tests asserting datetime/date_nanos cannot be mixed in joins
craigtaverner 3b0e70f
Merge remote-tracking branch 'origin/main' into lookup_join_date_nanos
craigtaverner f478122
Fix after merging main
craigtaverner 7de8ee7
Add unit tests for new DateFieldType methods
craigtaverner b61a325
Merge remote-tracking branch 'origin/main' into lookup_join_date_nanos
craigtaverner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| pr: 127962 | ||
| summary: Support DATE_NANOS in LOOKUP JOIN | ||
| area: ES|QL | ||
| type: bug | ||
| issues: | ||
| - 127249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth adding a couple of unit tests to
DateFieldTypeTestsjust so we can be sure these do reasonable things. These methods are so much simpler than the others, but it'd be nice to have something really simple to read the exercises it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done