Skip to content

[8.19] Default new semantic_text fields to use BBQ when models are compatible (#126629)#127831

Merged
kderusso merged 5 commits intoelastic:8.19from
kderusso:backport/8.19/pr-126629
May 7, 2025
Merged

[8.19] Default new semantic_text fields to use BBQ when models are compatible (#126629)#127831
kderusso merged 5 commits intoelastic:8.19from
kderusso:backport/8.19/pr-126629

Conversation

@kderusso
Copy link
Member

@kderusso kderusso commented May 7, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

elastic#126629)

* Default new semantic_text fields to use BBQ when models are compatible

* Update docs/changelog/126629.yaml

* Gate default BBQ by IndexVersion

* Cleanup from PR feedback

* PR feedback

* Fix test

* Fix test

* PR feedback

* Update test to test correct options

* Hack alert: Fix issue where mapper service was always being created with current index version

(cherry picked from commit a72883e)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexVersions.java
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticInferenceMetadataFieldsMapperTests.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapperTests.java
@kderusso kderusso requested a review from Mikep86 May 7, 2025 14:45
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mikep86
Copy link
Contributor

Mikep86 commented May 7, 2025

@elasticmachine update branch

@kderusso kderusso merged commit 024bf59 into elastic:8.19 May 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants