Skip to content

ESQL: Unmute test #127065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elasticsearchmachine merged 5 commits into from
Apr 21, 2025
Merged

ESQL: Unmute test #127065

elasticsearchmachine merged 5 commits into from
Apr 21, 2025

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 18, 2025 •
edited
Loading

It was assuming a simpler execution model. This weakens the assertion to one that should always pass.

Closes #127046
Closes #127039
Closes #127090
Closes #127080

@nik9000
ESQL: Unmute test
2b07bd6 
It was assuming a simpler execution model. This weakens the assertion to
one that should always pass.

Closes elastic#127046
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL v9.1.0 labels Apr 18, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 18, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 18, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

luigidellaquila
luigidellaquila approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsbauman
Copy link
Contributor

nielsbauman commented Apr 21, 2025

@nik9000 thanks for fixing this. Could you also unmute #127088 please? That one was initially assigned to Data Management but I reassigned it to Analytics.

@elasticsearchmachine elasticsearchmachine merged commit 5b351af into elastic:main Apr 21, 2025
17 checks passed
@nik9000 nik9000 deleted the esql_unmute_docs_yaml branch April 21, 2025 14:17
@nielsbauman
Copy link
Contributor

nielsbauman commented Apr 21, 2025

Ah, looks like my comment triggered the bot to merge the PR. It'll have to be unmuted in a follow-up PR.

@nik9000 nik9000 mentioned this pull request Apr 21, 2025
Closed
@nik9000
Copy link
Member Author

nik9000 commented Apr 21, 2025

Ah, looks like my comment triggered the bot to merge the PR. It'll have to be unmuted in a follow-up PR.

Surprise!

@alex-spies alex-spies mentioned this pull request Apr 23, 2025
Merged
@alex-spies
Copy link
Contributor

alex-spies commented Apr 23, 2025

Follow-up with remaining unmutes: #127228

alex-spies added a commit that referenced this pull request Apr 23, 2025
@alex-spies
ESQL: Remaining unmutes for esql/10_basic/basic with documents_found (#…
cf86cd7 
…127228)

Already fixed in #127065.
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Jul 7, 2025
@nik9000 @ioanatia
ESQL: Unmute test (elastic#127065)
1bbe40d 
It was assuming a simpler execution model. This weakens the assertion to
one that should always pass.

Closes elastic#127046 Closes elastic#127039 Closes elastic#127090 Closes elastic#127080
@ioanatia ioanatia mentioned this pull request Jul 7, 2025
Merged
ioanatia added a commit that referenced this pull request Jul 7, 2025
@ioanatia @nik9000
ESQL: Unmute test (#127065) (#130689)
8fd629f 
It was assuming a simpler execution model. This weakens the assertion to
one that should always pass.

Closes #127046 Closes #127039 Closes #127090 Closes #127080

Co-authored-by: Nik Everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Milestone

No milestone

5 participants

@nik9000 @elasticsearchmachine @nielsbauman @alex-spies @luigidellaquila