Skip to content

Improve cancellation test #122085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Improve cancellation test #122085

merged 1 commit into from
Feb 7, 2025

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Feb 7, 2025

  • Don't require specific message since cancel can take several forms
  • Stop both branches for close test to avoid race

Note this does not fully fix the test yet, since there's another problem there, but I am unmuting it anyway to get better visibility into it.

@smalyshev
Improve cancellation test
62122f9 
- Don't require specific message since cancel can take several forms
- Stop both branches for close test to avoid race
@smalyshev smalyshev requested a review from quux00 February 7, 2025 19:26
@smalyshev smalyshev added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.19.0 auto-backport Automatically create backport pull requests when merged v9.1.0 labels Feb 7, 2025
@smalyshev smalyshev requested a review from dnhatn February 7, 2025 19:27
@smalyshev smalyshev marked this pull request as ready for review February 7, 2025 19:27
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 7, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 7, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@smalyshev smalyshev enabled auto-merge (squash) February 7, 2025 19:37
@smalyshev smalyshev merged commit 5bdb339 into elastic:main Feb 7, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 7, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122085

@smalyshev smalyshev mentioned this pull request Feb 7, 2025
Merged
@smalyshev
Copy link
Contributor Author

smalyshev commented Feb 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 7, 2025
@smalyshev
Improve cancellation test (#122085) (#122093)
fc0752a 
- Don't require specific message since cancel can take several forms
- Stop both branches for close test to avoid race

(cherry picked from commit 5bdb339)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

@quux00 quux00 Awaiting requested review from quux00

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smalyshev @elasticsearchmachine @dnhatn