Skip to content

[8.x] ESQL: Fewer test cases for conversions (#119774)#119873

Merged
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
nik9000:backport/8.x/pr-119774
Jan 9, 2025
Merged

[8.x] ESQL: Fewer test cases for conversions (#119774)#119873
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
nik9000:backport/8.x/pr-119774

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Jan 9, 2025

Backports the following commits to 8.x:

This applies that pattern from elastic#119678 to the `convert` tests. It
doesn't buy us any speed, sadly. This is because conversions are *unary*
and we rarely get much bonus from unary functions for this. Still, we do
marginally reduce the number of test cases which is good for gradle:
```
13862 -> 11948 (14%)
```
@nik9000 nik9000 added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 9, 2025
@elasticsearchmachine elasticsearchmachine merged commit 0a0dac3 into elastic:8.x Jan 9, 2025
@nik9000 nik9000 deleted the backport/8.x/pr-119774 branch January 9, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants