Vector rescoring oversamples k instead of num_candidates#119835
Merged
carlosdelest merged 5 commits intoelastic:mainfrom Jan 10, 2025
Merged
Vector rescoring oversamples k instead of num_candidates#119835carlosdelest merged 5 commits intoelastic:mainfrom
carlosdelest merged 5 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Jan 10, 2025
Member
benwtrent
left a comment
There was a problem hiding this comment.
Great stuff! You may have issues with the api compat tests and thus they may need to be muted before backport. I am not sure.
Member
Author
I hope not as I changed the capability name - I'll keep an eye on this 👍 |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jan 10, 2025
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 10, 2025
This was referenced Jan 13, 2025
This was referenced Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes more sense to apply rescoring to an oversampled
kinstead ofnum_candidates, as rescoring just a fraction of the candidates will be more performant and offer good recall, specially for smaller k sizes compared to number of candidates.API changes so we use
oversampleinstead ofnum_candidates_factor:This will mean rescoring
k * oversamplefrom thenum_candidatesretrieved on each shard, and returning the topkout of them.Follow up to #116663