Semantic text with legacy format cannot store term vectors#119690
Merged
jimczi merged 2 commits intoelastic:mainfrom Jan 7, 2025
Merged
Semantic text with legacy format cannot store term vectors#119690jimczi merged 2 commits intoelastic:mainfrom
jimczi merged 2 commits intoelastic:mainfrom
Conversation
This change fixes the store option of the underlying sparse vector field for semantic text. For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.
jimczi
added
>non-issue
:SearchOrg/Relevance
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Mikep86
approved these changes
Jan 7, 2025
Contributor
Mikep86
left a comment
Mikep86
left a comment
There was a problem hiding this comment.
Thanks for fixing this, oversight on my part 🤦
jimczi
added
the
auto-backport
Collaborator
💚 Backport successful
|
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 7, 2025
…19690) This change fixes the store option of the underlying sparse vector field for semantic text. For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 8, 2025
…119695) This change fixes the store option of the underlying sparse vector field for semantic text. For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.
thekofimensah
pushed a commit
to thekofimensah/elasticsearch
that referenced
this pull request
Jan 14, 2025
…19690) This change fixes the store option of the underlying sparse vector field for semantic text. For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the store option of the underlying sparse vector field for semantic text. For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.