[test] Fix off-by-one error in RecoverySourcePruneMergePolicyTests#testPruneSome
#118944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `extra_source_size` field is set to a value between 10 and 10000 inclusive, so the assertion should be `greaterThanOrEqualTo(10)` rather than greaterThan(10). Resolve elastic#118728
arteam
added
>test
elasticsearchmachine
added
v9.0.0
Team:StorageEngine
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
arteam
added
auto-merge-without-approval
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
…#118944) The `extra_source_size` field is set to a value between 10 and 10000 inclusive, so the assertion should be `greaterThanOrEqualTo(10)` rather than `greaterThan(10)`. See elastic#114618 Resolve elastic#118728
arteam
added
v8.17.1
auto-backport
arteam
added a commit
that referenced
this pull request
Dec 18, 2024
…stPruneSome` Backports #118944 to 8.x
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 19, 2024
The test failure elastic#118728 was fixed by elastic#118944 but test wasn't unmuted.
martijnvg
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extra_source_sizefield is set to a value between 10 and 10000 inclusive, so the assertion should begreaterThanOrEqualTo(10)rather thangreaterThan(10).See #114618
Resolve #118728