Make ES|QL scoring tests running consistently in serverless#118854
Merged
tteofili merged 6 commits intoelastic:mainfrom Dec 18, 2024
Merged
Make ES|QL scoring tests running consistently in serverless#118854tteofili merged 6 commits intoelastic:mainfrom
tteofili merged 6 commits intoelastic:mainfrom
Conversation
enforce _id in books dataset to make doc distribution across shards consistent. books settings with 3 shards to accomodate serverless settings. unmuting scoring tests. scoring test fixed.
tteofili
added
:Analytics/ES|QL
…arch into books_sharding_scores
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
ioanatia
approved these changes
Dec 18, 2024
Contributor
ioanatia
left a comment
ioanatia
left a comment
There was a problem hiding this comment.
nice work fixing these tests! I know it was quite tedious!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
tteofili
added a commit
that referenced
this pull request
Dec 18, 2024
…18854) (#118928) * Make ES|QL scoring tests running consistently in serverless (#118854) * make scoring tests running consistently in serverless enforce _id in books dataset to make doc distribution across shards consistent. books settings with 3 shards to accomodate serverless settings. unmuting scoring tests. scoring test fixed. (cherry picked from commit 140beb1)
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
…118854) * make scoring tests running consistently in serverless enforce _id in books dataset to make doc distribution across shards consistent. books settings with 3 shards to accomodate serverless settings. unmuting scoring tests. scoring test fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces
_idfor each row within the (test)booksdataset; this results in document distribution being consistent across shards.Settings file was also added for the books dataset, to set the number of shards to 3 (to accomodate serverless CI settings).
CSV scoring tests for ES|QL have been fixed and unmuted.