Skip to content

Adjust the test based on the year change#118827

Merged
astefan merged 1 commit intoelastic:8.17from
astefan:118810_8.17_fix
Dec 17, 2024
Merged

Adjust the test based on the year change#118827
astefan merged 1 commit intoelastic:8.17from
astefan:118810_8.17_fix

Conversation

@astefan
Copy link
Contributor

@astefan astefan commented Dec 17, 2024

Fixes #118810

@astefan astefan added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying auto-backport Automatically create backport pull requests when merged v8.17.0 v8.17.1 labels Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and let's not forget to also forward port to 8.18/main + get rid of the mute there.

@alex-spies
Copy link
Contributor

Ah, main+8.x are taken care of in #118815

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.17
8.16

astefan added a commit to astefan/elasticsearch that referenced this pull request Dec 17, 2024
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.. for a while :)
I guess it can stay, but at some point it might be worth limiting the impact of TODAY()'s variation. (SELECT first_name, hire_date FROM employees WHERE hire_date > DATE_TRUNC('CENTURY', TODAY()) - INTERVAL 11 YEARS ORDER BY first_name ASC LIMIT 5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.17.27 v8.16.3 v8.17.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants