Skip to content

[8.x] ESQL: Disable LOOKUP JOIN physical optimizer test on release #118754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 2 commits into from
Dec 16, 2024
Merged

[8.x] ESQL: Disable LOOKUP JOIN physical optimizer test on release #118754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3e372
Disable test on release builds
alex-spies Dec 16, 2024
187e13f
Unmute
alex-spies Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,6 @@ tests:
- class: org.elasticsearch.xpack.application.HuggingFaceServiceUpgradeIT
method: testElser {upgradedNodes=1}
issue: https://github.com/elastic/elasticsearch/issues/118127
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testVerifierOnMissingReferencesWithBinaryPlans {default}
issue: https://github.com/elastic/elasticsearch/issues/118707
- class: org.elasticsearch.xpack.application.CohereServiceUpgradeIT
method: testCohereEmbeddings {upgradedNodes=1}
issue: https://github.com/elastic/elasticsearch/issues/116974
Expand Down
2 changes: 2 additions & 0 deletions ...esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2329,6 +2329,8 @@ public void testVerifierOnMissingReferences() {
}

public void testVerifierOnMissingReferencesWithBinaryPlans() throws Exception {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());

// Do not assert serialization:
// This will have a LookupJoinExec, which is not serializable because it doesn't leave the coordinator.
var plan = physicalPlan("""
Expand Down