Merged
Conversation
carlosdelest
added
>test
carlosdelest
added
auto-backport
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml # rest-api-spec/build.gradle
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml # rest-api-spec/build.gradle # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/90_synonyms_reloading_for_synset.yml
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml # rest-api-spec/build.gradle # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/90_synonyms_reloading_for_synset.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Fix BwC synonyms tests (#118691) (cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml # rest-api-spec/build.gradle # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/90_synonyms_reloading_for_synset.yml * Fix merge --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
Merged
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
(cherry picked from commit d09d57d) # Conflicts: # muted-tests.yml # rest-api-spec/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116777
BwC tests can't work with synonyms correctly, as auto expand replicas 0-all in the synonyms system index means that not all replicas will be available for the synonyms index when upgrading nodes to create a mixed cluster.
This makes some shard update failure in the synonyms operations as there can be race conditions on the update operations for shards that are marked as relocating. I haven't found a way to consistently deal with this on BwC on reload operations.
This PR creates two different tests for reloading synonyms, in which different conditions are checked. The conditions that fail in BwC are added to a test that is skipped in BwC. This way we have some coverage for both BwC and non-BwC tests, and we check all conditions needed in non-BwC tests.
When we have auto-expand replicas set to 0-1 in synonyms system index, this can be reverted. That is tracked in #115382