ESQL: Skip lookup fields when eliminating missing fields#118658
Merged
alex-spies merged 10 commits intoelastic:mainfrom Dec 17, 2024
Merged
ESQL: Skip lookup fields when eliminating missing fields#118658alex-spies merged 10 commits intoelastic:mainfrom
alex-spies merged 10 commits intoelastic:mainfrom
Conversation
alex-spies
commented
Dec 13, 2024
| /** | ||
| * LOOKUP JOIN | ||
| */ | ||
| JOIN_LOOKUP_V5(Build.current().isSnapshot()), |
Contributor
Author
There was a problem hiding this comment.
To be merged after #118429, so I bumped the capability by 2 right away.
alex-spies
added
>non-issue
auto-backport
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
I contemplated adding also optimizer (unit) tests; not sure we want them, as those would have to test that a rule does nothing - which is not entirely correct, it just can't do anything at the moment due to missing SearchStats. |
This was referenced Dec 13, 2024
alex-spies
commented
Dec 16, 2024
| 3 | Error | ||
| ; | ||
|
|
||
| lookupWithFieldOnJoinKey-Ignore |
Contributor
Author
There was a problem hiding this comment.
This has become filterOnJoinKeyAndRightSide, one test case below.
alex-spies
added
the
auto-merge-without-approval
Contributor
Author
|
CI only failed on JdbcDocCsvSpecIT » test {docs.testFilterToday}, which is in the process of being fixed - so this should be fine to merge. |
Collaborator
💚 Backport successful
|
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Dec 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
…118836) We do not have SearchStats for fields from lookup indices. And unfortunately, these are hard to obtain. For now, just do not apply ReplaceMissingFieldWithNull to fields coming from an index used in LOOKUP JOIN. These are identified via their indexmode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not have SearchStats for fields from lookup indices. And unfortunately, these are hard to obtain.
For now, just do not apply ReplaceMissingFieldWithNull to fields coming from an index used in
LOOKUP JOIN. These are identified via their indexmode.