ESQL: Disable tests planned incorrectly on pre-8.13 (failing BWC) #118655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpintea
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Contributor
Author
|
Note: this has no effect on main, but I'd like to keep the files in sync with 8.x for easy backporting. |
alex-spies
approved these changes
Dec 13, 2024
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
LGTM.
Should we enable the auto-backport label, or did you wanna backport manually?
Contributor
Author
|
Thanks, Alex.
I do, to re-enable the disabled tests. |
bpintea
added
the
auto-merge-without-approval
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 13, 2024
This prevents two tests in `grok` and `dissect` suites - `overwriteName` and `overwriteNameWhere` and one in the `stats` suite - `byStringAndLongWithAlias` - to run against pre-8.13.0 versions. Reason being that coordinators prior to that version can generate invalid node plans, that'd fail (verification) on 8.18+ nodes. (cherry picked from commit 0441555)
bpintea
changed the title
bpintea
changed the title
bpintea
changed the title
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2024
…18655) (#118685) * ESQL: Disable grok.OverwriteName* on pre-8.13 BWC tests (#118655) This prevents two tests in `grok` and `dissect` suites - `overwriteName` and `overwriteNameWhere` and one in the `stats` suite - `byStringAndLongWithAlias` - to run against pre-8.13.0 versions. Reason being that coordinators prior to that version can generate invalid node plans, that'd fail (verification) on 8.18+ nodes. (cherry picked from commit 0441555) * re-enabled disabled tests
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2024
Prevent `stats.ByStringAndLongWithAlias` from running on pre-8.13 BWC. Related #118655.
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 16, 2024
Prevent `stats.ByStringAndLongWithAlias` from running on pre-8.13 BWC. Related elastic#118655. (cherry picked from commit 0efdc47)
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…astic#118655) (elastic#118685) * ESQL: Disable grok.OverwriteName* on pre-8.13 BWC tests (elastic#118655) This prevents two tests in `grok` and `dissect` suites - `overwriteName` and `overwriteNameWhere` and one in the `stats` suite - `byStringAndLongWithAlias` - to run against pre-8.13.0 versions. Reason being that coordinators prior to that version can generate invalid node plans, that'd fail (verification) on 8.18+ nodes. (cherry picked from commit 0441555) * re-enabled disabled tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents two tests in
grokanddissectsuites -overwriteNameandoverwriteNameWhereand one in thestatssuite -byStringAndLongWithAlias- to run against pre-8.13.0 versions. Reason being that coordinators prior to that version can generate invalid node plans, that'd fail (verification) on 8.18+ nodes.