Replace Fixed build with scope parameter#118643
Merged
idegtiarenko merged 5 commits intoelastic:mainfrom Dec 17, 2024
Merged
Conversation
This change replaces the build with scope parameter in order to make it cleaner when parameter is build and how it is used.
idegtiarenko
added
>non-issue
Team:Analytics
idegtiarenko
commented
Dec 13, 2024
Comment on lines
-37
to
+47
| boolean build() default false; | ||
| Scope scope() default Scope.SINGLETON; | ||
|
|
||
| /** | ||
| * Defines the parameter scope | ||
| */ | ||
| enum Scope { | ||
| /** | ||
| * Should be used for immutable parameters that can be shared across different threads | ||
| */ | ||
| SINGLETON, | ||
| /** | ||
| * Should be used for mutable or not thread safe parameters | ||
| */ | ||
| THREAD_LOCAL, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The main change is here.
Please let me know if you have a better naming in mind.
nik9000
approved these changes
Dec 16, 2024
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM. It's nice to see that we don't change any of the generated files with this.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
force-pushed
the
update_fixed_annotation
branch
from
9face5f to
721c0f1
Compare
idegtiarenko
added
the
auto-backport
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Dec 18, 2024
This change replaces the build with scope parameter in order to make it cleaner when parameter is build and how it is used. (cherry picked from commit b8f4677)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the
@Fixedbuild with scope parameter in order to make it cleaner when parameter is build and how it is used.