Fix bug in InferenceUpgradeTestCase.getConfigsWithBreakingChangeHandling#118624
Merged
original-brownbear merged 2 commits intoelastic:mainfrom Dec 13, 2024
Merged
Conversation
We need to load the two fields from the same response. Otherwise, we can have a sort of race where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node also empty, resulting in an empty list because we took the wrong info from either response. closes #118163
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
maxhniebergall
approved these changes
Dec 12, 2024
Contributor
maxhniebergall
left a comment
maxhniebergall
left a comment
There was a problem hiding this comment.
LGTM! Thanks so much for your help. I'll make sure to backport this change and unmute the tests.
maxhniebergall
added
auto-backport
Contributor
Author
|
npnp :) sorry fell asleep before merging last night :D |
Collaborator
This was referenced Dec 13, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ing (#118624) (#118663) We need to load the two fields from the same response. Otherwise, we can have a sort of race where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node also empty, resulting in an empty list because we took the wrong info from either response. closes #118163
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2024
…ing (#118624) (#118664) We need to load the two fields from the same response. Otherwise, we can have a sort of race where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node also empty, resulting in an empty list because we took the wrong info from either response. closes #118163 Co-authored-by: Max Hniebergall <137079448+maxhniebergall@users.noreply.github.com>
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
…ing (elastic#118624) (elastic#118663) We need to load the two fields from the same response. Otherwise, we can have a sort of race where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node also empty, resulting in an empty list because we took the wrong info from either response. closes elastic#118163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to load the two fields from the same response. Otherwise, we can have a sort of race where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node also empty, resulting in an empty list because we took the wrong info from either response.
closes #118163