Updating inference services API response#118491
Conversation
ymao1
added
:ml
|
Hi @ymao1, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM, I have a couple of suggestions
The output contains lots of entries like "default_value": null,. In SettingsConfiguration#toXContent() please can you wrap writing default_value in a null check.
The service configurations are not sorted as order they are written depends on the iteration order of a map. Sorting the individual configs by service would make the output more readable.
Updated in 8e1562d
Updated in bc1922d |
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
LGTM! Tested locally, works as expected.
* Updating inference services API response * Update docs/changelog/118491.yaml * Delete docs/changelog/118491.yaml * Skip writing null default value config * Sorting output by service name * Updating Jina AI * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit 82b1f2a) # Conflicts: # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Updating inference services API response (#118491) * Updating inference services API response * Update docs/changelog/118491.yaml * Delete docs/changelog/118491.yaml * Skip writing null default value config * Sorting output by service name * Updating Jina AI * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit 82b1f2a) # Conflicts: # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java * Adding the get services api back * Removing eis references because they aren't merged yet --------- Co-authored-by: Ying Mao <ying.mao@elastic.co>
5 participants
❗❗This should not be merged until elastic/kibana#203363 is released to serverless
Resolves https://github.com/elastic/ml-team/issues/1428
Summary
Updates the
GET _inference/_servicesAPI to follow the new agreed upon response format.For the new
updatablefield, I followed the guidance from API docs which saysyou can modify task_settings, secrets (within service_settings), or num_allocations, depending on the specific endpoint service and task_type you’ve created, so the only fields withupdatable: trueare secret settings field andnum_allocations.