Skip to content

Improve InputStreamIndexInput testSkipBytes#118485

Merged
kingherc merged 3 commits intoelastic:mainfrom
kingherc:non-issue/ES-10234-improve-test
Dec 12, 2024
Merged

Improve InputStreamIndexInput testSkipBytes#118485
kingherc merged 3 commits intoelastic:mainfrom
kingherc:non-issue/ES-10234-improve-test

Conversation

@kingherc
Copy link
Copy Markdown
Contributor

@kingherc kingherc commented Dec 11, 2024

Instigated from this comment.

Relates ES-10234

@kingherc kingherc added >non-issue :Distributed/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. auto-backport Automatically create backport pull requests when merged v9.0.0 Team:Distributed Indexing (obsolete) Meta label for Distributed Indexing team. Obsolete. Please do not use. v8.18.0 labels Dec 11, 2024
@kingherc kingherc self-assigned this Dec 11, 2024
@kingherc kingherc requested a review from bcully December 11, 2024 16:57
@kingherc kingherc mentioned this pull request Dec 11, 2024
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Dec 11, 2024

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

bcully
bcully approved these changes Dec 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bcully bcully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread server/src/test/java/org/elasticsearch/common/lucene/store/InputStreamIndexInputTests.java Outdated
bcully
bcully approved these changes Dec 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bcully bcully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kingherc kingherc merged commit ff8e5e9 into elastic:main Dec 12, 2024
kingherc added a commit to kingherc/elasticsearch that referenced this pull request Dec 12, 2024
@kingherc
Improve InputStreamIndexInput testSkipBytes (elastic#118485)
1688c11 
Relates ES-10234
@kingherc kingherc mentioned this pull request Dec 12, 2024
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Dec 12, 2024

💚 Backport successful

Status Branch Result
✅ 8.x

@kingherc kingherc deleted the non-issue/ES-10234-improve-test branch December 12, 2024 07:46
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
@kingherc
Improve InputStreamIndexInput testSkipBytes (#118485) (#118522)
34f9146 
Relates ES-10234
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
@kingherc
Improve InputStreamIndexInput testSkipBytes (elastic#118485) (elastic…
32acb0e 
…#118522)

Relates ES-10234
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
@kingherc
Improve InputStreamIndexInput testSkipBytes (elastic#118485) (elastic…
be3e3ad 
…#118522)

Relates ES-10234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcully bcully bcully approved these changes

Assignees

@kingherc kingherc

Labels

auto-backport Automatically create backport pull requests when merged :Distributed/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. >non-issue Team:Distributed Indexing (obsolete) Meta label for Distributed Indexing team. Obsolete. Please do not use. v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kingherc @elasticsearchmachine @bcully