Skip to content

[ML] Fixing streaming tests locale issue#118481

Merged
jonathan-buttner merged 2 commits intoelastic:mainfrom
jonathan-buttner:ml-streaming-tests-v2
Dec 11, 2024
Merged

[ML] Fixing streaming tests locale issue#118481
jonathan-buttner merged 2 commits intoelastic:mainfrom
jonathan-buttner:ml-streaming-tests-v2

Conversation

@jonathan-buttner
Copy link
Contributor

Addresses the test failures here: #118453
#118405

Fixes #118453 #118405

The issue is the locale so we're using Locale.ROOT now.

@jonathan-buttner jonathan-buttner added >test Issues or PRs that are addressing/adding tests :ml Machine learning Team:ML Meta label for the ML team v9.0.0 v8.18.0 labels Dec 11, 2024
@jonathan-buttner jonathan-buttner marked this pull request as ready for review December 11, 2024 16:19
@jonathan-buttner jonathan-buttner linked an issue Dec 11, 2024 that may be closed by this pull request
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Dec 17, 2024
* Fixing the string locale

* Missing a toUpper

(cherry picked from commit 5572777)

# Conflicts:
#	muted-tests.yml
jonathan-buttner added a commit that referenced this pull request Dec 17, 2024
* Fixing the string locale

* Missing a toUpper

(cherry picked from commit 5572777)

# Conflicts:
#	muted-tests.yml
@jonathan-buttner jonathan-buttner deleted the ml-streaming-tests-v2 branch January 31, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] InferenceCrudIT.testSupportedStream failing [CI] InferenceCrudIT testUnifiedCompletionInference failing

3 participants