Skip to content

[8.x] Specialize skip for InputStreamIndexInput (#118436) #118477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elasticsearchmachine merged 1 commit into from
Dec 11, 2024
Merged

[8.x] Specialize skip for InputStreamIndexInput (#118436) #118477

elasticsearchmachine merged 1 commit into from
Dec 11, 2024

Conversation

@kingherc
Copy link
Contributor

@kingherc kingherc commented Dec 11, 2024

Backports the following commits to 8.x:

@kingherc
Specialize skip for InputStreamIndexInput (elastic#118436)
49d83ca 
Skip would previously defer to the default implementation that
reads bytes unnecessarily and may be slow. We now specialize it
so that it seeks quickly.

Closes ES-10234
@kingherc kingherc added :Core/Infra/Core Core issues without another label :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team labels Dec 11, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Dec 11, 2024
Merged
@elasticsearchmachine elasticsearchmachine merged commit d553989 into elastic:8.x Dec 11, 2024
15 checks passed
@kingherc kingherc deleted the backport/8.x/pr-118436 branch December 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Core Core issues without another label :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. >non-issue Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team v8.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kingherc @elasticsearchmachine